changed dimensions of modal and made centered in viewport #369
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecliu1204
added a commit
that referenced
this pull request
Jul 22, 2025
* Update code to match main * Clean reset: make develop code match main exactly * Light and Dark mode Colour scheme changes (#360) added visual improvements to CourseCard, Navbar, ReviewCard and tailwind.config.js * added clickable course code for bookmarked reviews (#364) * added link icon and clickable course code to bookmarked reviews * Make bookmarked review titles clickable, added link icon * added clickable course code to card view of bookmarked reviews --------- Co-authored-by: Annelise Koh <[email protected]> * fixed bug for card/list toggle when there were no user reviews/bookmarked reviews (#362) * colour changes (#361) * Update code to match main * Clean reset: make develop code match main exactly * Light and Dark mode Colour scheme changes (#360) added visual improvements to CourseCard, Navbar, ReviewCard and tailwind.config.js --------- Co-authored-by: Auston Yang <[email protected]> * fixed card/list toggle only for when there are user reviews and user bookmarked reviews * removed extra file --------- Co-authored-by: alecliu1204 <[email protected]> Co-authored-by: Auston Yang <[email protected]> Co-authored-by: Lyn Duong <[email protected]> * added hover colouring for bookmarked reviews (#363) * colour changes (#361) * Update code to match main * Clean reset: make develop code match main exactly * Light and Dark mode Colour scheme changes (#360) added visual improvements to CourseCard, Navbar, ReviewCard and tailwind.config.js --------- Co-authored-by: Auston Yang <[email protected]> * added hover colouring to bookmarked cards --------- Co-authored-by: alecliu1204 <[email protected]> Co-authored-by: Auston Yang <[email protected]> Co-authored-by: Lyn Duong <[email protected]> * moved link icon to the right of course code and made icon smaller (#365) * added link icon and clickable course code to bookmarked reviews * Make bookmarked review titles clickable, added link icon * added clickable course code to card view of bookmarked reviews * made link icon smaller and moved it to the right of course code --------- Co-authored-by: Annelise Koh <[email protected]> Co-authored-by: alecliu1204 <[email protected]> * Feature/filter and reviews (#368) * Added animation to modal popup for Filter * colour changes (#361) * Update code to match main * Clean reset: make develop code match main exactly * Light and Dark mode Colour scheme changes (#360) added visual improvements to CourseCard, Navbar, ReviewCard and tailwind.config.js --------- Co-authored-by: Auston Yang <[email protected]> * Fixed filter animation and padding * Fixed text only review always --------- Co-authored-by: alecliu1204 <[email protected]> Co-authored-by: Auston Yang <[email protected]> * changed dimensions of modal and made centered in viewport (#369) changed dimensions of modal and made centered in viewport excluding navbar --------- Co-authored-by: Auston Yang <[email protected]> Co-authored-by: annelise_k <[email protected]> Co-authored-by: Annelise Koh <[email protected]> Co-authored-by: l-duong05 <[email protected]> Co-authored-by: Lyn Duong <[email protected]> Co-authored-by: Xx358hffy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also formatted