Skip to content

Conversation

superninja-app[bot]
Copy link

@superninja-app superninja-app bot commented Sep 16, 2025

This PR fixes issues with the LocalTesting implementation:

  1. Fixed compilation errors in FlinkDotNetJobs.cs:

    • Updated return type from FlinkDotNet.Pipelines.SubmitResult to Flink.JobBuilder.Models.JobSubmissionResult
    • Removed unnecessary using directives
    • Fully qualified types to avoid namespace conflicts
  2. Fixed unused variable warnings in Program.cs

  3. Improved the LocalTesting environment setup:

    • Updated the csproj file to properly build and include the JAR
    • Fixed the path resolution for the FlinkIRRunner directory
    • Added proper error handling for when Java or Maven are not available
    • Configured the environment with 1 Kafka, 1 FlinkDotnet, 1 Flink JobManager, and 1 Flink TaskManager
    • Added diagnostic logging to help troubleshoot issues
  4. Updated the test implementation to work with the current setup:

    • Added more detailed logging to the test
    • Improved error handling in the test
    • Ensured the test uses the correct environment variables

These changes ensure that the LocalTesting environment works correctly and the tests pass.

1. Added Java and Maven installation to Gateway's Dockerfile
2. Updated Gateway build process to include building the Java project
3. Simplified LocalTesting to have a single test with a basic flow
4. Set up test environment with 1 Kafka, 1 FlinkDotnet, 1 Flink JobManager, and 1 Flink TaskManager
5. Implemented multiple FlinkDotnet jobs covering all implementations
6. Updated .gitignore to exclude generated JAR files
@superninja-app superninja-app bot requested a review from devstress as a code owner September 16, 2025 14:13
@devstress devstress merged commit 841db73 into Darren/Fix-LocalTesting Sep 16, 2025
2 of 3 checks passed
@devstress devstress deleted the fix/gateway-build-and-localtesting branch September 16, 2025 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant