feat: add check-endpoints command
#85
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpahlavi
force-pushed
the
lpahlavi/XC-391-add-check-endpoints-command
branch
from
c7e7916 to
6f13643
Compare
lpahlavi
force-pushed
the
lpahlavi/XC-391-add-check-endpoints-command
branch
from
672d3fb to
fdb03c0
Compare
lpahlavi
force-pushed
the
lpahlavi/XC-391-add-check-endpoints-command
branch
from
d11dc0a to
a127e6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(XC-391) Add the
check-endpointscommand which allows comparing the endpoints exposed in a canister's WASM against those exposed in the canister's Candid interface file (i.e..didfile) to ensure no unexpected endpoints are exposed. The command is only added to theic-wasmbinary if thecheck-endpointsfeature is enabled.The
check-endpointscommand also has a--hiddenflag to allow endpoints being explicitly hidden from the Candid interface (e.g. anhttp_requestendpoint).A follow-up PR will enable using the new command within a new
ic-wasmGitHub action to verify a canister's endpoints against its Candid interface within a CI pipeline.