-
Notifications
You must be signed in to change notification settings - Fork 153
Improve illustrations and migration steps UI #3249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR improves the UI and user experience of the migration wizard flow by replacing complex inline SVG illustrations with modular components, enhancing input validation, and improving accessibility. The changes focus on making the migration process more user-friendly and maintainable.
- Replaced inline SVG illustrations with modular flex-based components for better maintainability
- Enhanced form input validation and accessibility with numeric-only input and autofocus
- Added helpful UI hints and centralized configuration usage
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
EnterIdentityNumber.svelte | Added numeric input validation, autofocus, and centralized support URL usage |
CreatePasskeyMigration.svelte | Added autofocus and helpful hint for passkey name input |
SmileyWritingIllustration.svelte | Simplified SVG illustration with modern, cleaner design |
MigrationIllustration.svelte | Replaced complex inline SVG with modular flex layout using separate components |
LogoLegacy.svelte | New component containing the legacy logo SVG for the migration illustration |
Comments suppressed due to low confidence (1)
src/frontend/src/lib/components/wizards/migration/views/EnterIdentityNumber.svelte:84
- The 'type="number"' attribute is being removed but the line is still shown in the diff. This appears to be an inconsistency in the diff representation, as the input validation logic suggests this should be a text input with custom numeric validation.
size="md"
src/frontend/src/lib/components/wizards/migration/views/CreatePasskeyMigration.svelte
Outdated
Show resolved
Hide resolved
…PasskeyMigration.svelte Co-authored-by: Copilot <[email protected]>
src/frontend/src/lib/components/illustrations/LogoLegacy.svelte
Outdated
Show resolved
Hide resolved
src/frontend/src/lib/components/illustrations/MigrationIllustration.svelte
Outdated
Show resolved
Hide resolved
src/frontend/src/lib/components/illustrations/SmileyWritingIllustration.svelte
Outdated
Show resolved
Hide resolved
src/frontend/src/lib/components/illustrations/SmileyWritingIllustration.svelte
Outdated
Show resolved
Hide resolved
src/frontend/src/lib/components/illustrations/SmileyWritingIllustration.svelte
Outdated
Show resolved
Hide resolved
src/frontend/src/lib/components/illustrations/SmileyWritingIllustration.svelte
Show resolved
Hide resolved
src/frontend/src/lib/components/wizards/migration/views/CreatePasskeyMigration.svelte
Outdated
Show resolved
Hide resolved
src/frontend/src/lib/components/wizards/migration/views/CreatePasskeyMigration.svelte
Outdated
Show resolved
Hide resolved
src/frontend/src/lib/components/wizards/migration/views/EnterIdentityNumber.svelte
Outdated
Show resolved
Hide resolved
src/frontend/src/lib/components/wizards/migration/views/EnterIdentityNumber.svelte
Outdated
Show resolved
Hide resolved
src/frontend/src/lib/components/wizards/migration/views/EnterIdentityNumber.svelte
Outdated
Show resolved
Hide resolved
src/frontend/src/lib/components/wizards/migration/views/EnterIdentityNumber.svelte
Outdated
Show resolved
Hide resolved
src/frontend/src/lib/components/wizards/migration/views/CreatePasskeyMigration.svelte
Outdated
Show resolved
Hide resolved
src/frontend/src/lib/components/illustrations/LogoLegacy.svelte
Outdated
Show resolved
Hide resolved
src/frontend/src/lib/components/illustrations/LogoLegacy.svelte
Outdated
Show resolved
Hide resolved
src/frontend/src/lib/components/wizards/migration/views/EnterIdentityNumber.svelte
Outdated
Show resolved
Hide resolved
src/frontend/src/lib/components/wizards/migration/views/EnterIdentityNumber.svelte
Show resolved
Hide resolved
src/frontend/src/lib/components/wizards/migration/views/EnterIdentityNumber.svelte
Show resolved
Hide resolved
src/frontend/src/lib/components/illustrations/LogoLegacy.svelte
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Motivation
Address comments raised in #3245
Changes
MigrationIllustration.svelte
with a flex layout using three components:LogoLegacy
,ArrowRight
, and the newLogo
, making the illustration more modular and maintainable. (MigrationIllustration.svelte
,LogoLegacy.svelte
)SmileyWritingIllustration.svelte
to use a simplified, modern SVG illustration with a new layout and removed legacy code. (SmileyWritingIllustration.svelte
)CreatePasskeyMigration.svelte
,EnterIdentityNumber.svelte
)EnterIdentityNumber.svelte
)CreatePasskeyMigration.svelte
,EnterIdentityNumber.svelte
)SUPPORT_URL
constant instead of a hardcoded URL, improving maintainability. (EnterIdentityNumber.svelte
)Tests
Tested locally that the migration flow is still rendered as expected in both themes and mobile