Skip to content

Improve illustrations and migration steps UI #3249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 11, 2025
Merged

Conversation

lmuntaner
Copy link
Collaborator

@lmuntaner lmuntaner commented Aug 8, 2025

Motivation

Address comments raised in #3245

Changes

  • Replaced the inline SVG in MigrationIllustration.svelte with a flex layout using three components: LogoLegacy, ArrowRight, and the new Logo, making the illustration more modular and maintainable. (MigrationIllustration.svelte, LogoLegacy.svelte)
  • Updated SmileyWritingIllustration.svelte to use a simplified, modern SVG illustration with a new layout and removed legacy code. (SmileyWritingIllustration.svelte)
  • Adjusted the layout in migration wizard views to wrap illustrations in flex containers for better alignment and spacing. (CreatePasskeyMigration.svelte, EnterIdentityNumber.svelte)
  • Enhanced the identity number input to restrict input to numeric values only, improving accessibility and preventing user errors. (EnterIdentityNumber.svelte)
  • Added autofocus to key input fields and provided a helpful hint for the passkey name input, guiding users to pick a recognizable name. (CreatePasskeyMigration.svelte, EnterIdentityNumber.svelte)
  • Updated the support button to use the centralized SUPPORT_URL constant instead of a hardcoded URL, improving maintainability. (EnterIdentityNumber.svelte)

Tests

Tested locally that the migration flow is still rendered as expected in both themes and mobile

@lmuntaner lmuntaner marked this pull request as ready for review August 8, 2025 07:41
@lmuntaner lmuntaner requested a review from Copilot August 8, 2025 07:41
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the UI and user experience of the migration wizard flow by replacing complex inline SVG illustrations with modular components, enhancing input validation, and improving accessibility. The changes focus on making the migration process more user-friendly and maintainable.

  • Replaced inline SVG illustrations with modular flex-based components for better maintainability
  • Enhanced form input validation and accessibility with numeric-only input and autofocus
  • Added helpful UI hints and centralized configuration usage

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
EnterIdentityNumber.svelte Added numeric input validation, autofocus, and centralized support URL usage
CreatePasskeyMigration.svelte Added autofocus and helpful hint for passkey name input
SmileyWritingIllustration.svelte Simplified SVG illustration with modern, cleaner design
MigrationIllustration.svelte Replaced complex inline SVG with modular flex layout using separate components
LogoLegacy.svelte New component containing the legacy logo SVG for the migration illustration
Comments suppressed due to low confidence (1)

src/frontend/src/lib/components/wizards/migration/views/EnterIdentityNumber.svelte:84

  • The 'type="number"' attribute is being removed but the line is still shown in the diff. This appears to be an inconsistency in the diff representation, as the input validation logic suggests this should be a text input with custom numeric validation.
      size="md"

@lmuntaner lmuntaner requested a review from sea-snake August 11, 2025 09:53
@lmuntaner lmuntaner requested a review from sea-snake August 11, 2025 10:44
Copy link
Contributor

@sea-snake sea-snake left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lmuntaner lmuntaner added this pull request to the merge queue Aug 11, 2025
Merged via the queue into main with commit 4b56199 Aug 11, 2025
128 of 134 checks passed
@lmuntaner lmuntaner deleted the lm-improve-ui-migration branch August 11, 2025 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants