Feature/dhall lsp server #843
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hmm, https://ghc.haskell.org/trac/ghc/ticket/13112, not sure what to do, the problem appeared while building Maybe we can skip windows build on ghc-8.6.3? Can we use ghc-8.6.2 instead? |
PanAeon
force-pushed
the
feature/dhall-lsp-server
branch
2 times, most recently
from
1c2ada7 to
6641043
Compare
PanAeon
force-pushed
the
feature/dhall-lsp-server
branch
from
6641043 to
79f577d
Compare
|
This looks great! I'm fine with the MIT license for the project and I can add the Nix changes in a follow-up pull request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You might want to update (or just ask me to update) licenses accordingly. Also I did't touch
nixbits and CI bits. If you unhappy with anything in this pull request, just let me know.