Rebuild-goto-functions: call get_language_options #1435
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this, a rebuilt entry point would not obey command-line options such as --java-assume-inputs-non-null.
|
Ah yes knew there was a reason to get #1409 merged ASAP rather than wait, any reason to prefer this or the other one that you can see? |
thk123
approved these changes
Oct 2, 2017
|
Yours is slightly better (preconditions), merge that one
…On 2 Oct 2017 5:57 p.m., "Thomas Kiley" ***@***.***> wrote:
***@***.**** approved this pull request.
Fine but dupes #1409 <#1409>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1435 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AARTW8iFlHTxRwIMM-o-BsP_26ASKbA3ks5soRXxgaJpZM4Pq0eH>
.
{"api_version":"1.0","publisher":{"api_key":"
05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":
{"external_key":"github/diffblue/cbmc","title":"
diffblue/cbmc","subtitle":"GitHub repository","main_image_url":"
https://cloud.githubusercontent.com/assets/143418/17495839/a5054eac-5d88-
11e6-95fc-7290892c7bb5.png","avatar_image_url":"https://
cloud.githubusercontent.com/assets/143418/15842166/
7c72db34-2c0b-11e6-9aed-b52498112777.png","action":{"name":"Open in
GitHub","url":"https://github.com/diffblue/cbmc"}},"updates"
***@***.*** approved
#1435"}],"action":{"name":"View Pull Request","url":"https://
github.com/diffblue/cbmc/pull/1435#pullrequestreview-66521715"}}}
|
|
Closing as duplicate of #1409 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this, a rebuilt entry point would not obey command-line options such as --java-assume-inputs-non-null. Required to migrate test-gen to initialize_goto_model, which calls rebuild-start-function.