Skip to content

Enable casting from derived types to other derived types #1531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 27, 2017
Merged

Enable casting from derived types to other derived types #1531

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/util/expr_cast.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ auto expr_try_dynamic_cast(TExpr &base)
typename detail::expr_try_dynamic_cast_return_typet<T, TExpr>::type
returnt;
static_assert(
std::is_same<typename std::decay<TExpr>::type, exprt>::value,
std::is_base_of<exprt, typename std::decay<TExpr>::type>::value,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider is_assignable for more generality.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Considered and rejected!

"Tried to expr_try_dynamic_cast from something that wasn't an exprt");
static_assert(
std::is_base_of<exprt, T>::value,
Expand Down