Fix for cbmc running out of memory while printing traces using json_ui #1767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NlightNFotis
force-pushed
the
peter-json-fix
branch
from
b6928c7 to
a636d41
Compare
NlightNFotis
force-pushed
the
peter-json-fix
branch
from
a636d41 to
94b792c
Compare
|
@NlightNFotis, do you have evidence that this now indeed fixes/mitigates the problem? |
|
As discussed directly, to avoid conflicts with the current rebasing efforts, I will not make a PR for the |
|
Follow-up from chatting with @peterschrammel and @NlightNFotis : goto-analyzer-develop will not be directly merged, so a PR against develop would be good as well. |
|
This was the first attempt at solving the problem with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There has been a bug reported to us where
cbmcwould run out of memory while creating a huge json object in memory to report the traces with. This is changing the tracing report facility to use a new json class that streams the objects immediately as created, and therefore fixes the issue.