Turn string constraints into a struct #1784
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romainbrenguier
requested review from
chrisr-diffblue,
kroening,
martin-cs,
peterschrammel,
smowton and
tautschnig
as code owners
LAJW
approved these changes
Jan 31, 2018
romainbrenguier
force-pushed
the
refactor/turn-constraint-into-struct
branch
2 times, most recently
from
7af265f to
453845a
Compare
romainbrenguier
force-pushed
the
refactor/turn-constraint-into-struct
branch
5 times, most recently
from
9562529 to
d4dee60
Compare
romainbrenguier
force-pushed
the
refactor/turn-constraint-into-struct
branch
2 times, most recently
from
50a8064 to
03693d6
Compare
romainbrenguier
force-pushed
the
refactor/turn-constraint-into-struct
branch
4 times, most recently
from
797a71d to
2063358
Compare
Use standard algorithm instead of defining a visitor class
Doxygen gives warning on this link command, because it is not able to resolve it.
Make doxygen stop complaining about missing fields.
Lower bound should not use java_type
romainbrenguier
force-pushed
the
refactor/turn-constraint-into-struct
branch
from
2063358 to
9b06e39
Compare
|
This is now outdated and similar changes were made in another PR which is now merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This used to be a class. But we can have it a a simple struct instead, and the code looks simpler.