[SV-COMP'18 13/19] Memcpy assertions #2002
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smowton
reviewed
Apr 9, 2018
| "void CBMC_trace(int lvl, const char *event, ...);\n" | ||
|
|
||
| // pointers | ||
| "unsigned __CPROVER_POINTER_OBJECT(const void *p);\n" |
There was a problem hiding this comment.
Convention: I think these are usually __CPROVER_lowercase_name
There was a problem hiding this comment.
The above seems to have been re-introduced after it got moved out into cprover_builtin_headers.h
|
BTW, there's now __CPROVER_ssize_t! |
kroening
reviewed
May 22, 2018
| __CPROVER_POINTER_OFFSET(src) + n < __CPROVER_POINTER_OFFSET(dst) || | ||
| __CPROVER_POINTER_OFFSET(dst) + n < __CPROVER_POINTER_OFFSET(src), | ||
| "strcpy src/dst overlap"); | ||
| } |
There was a problem hiding this comment.
The precondition needs to be at the head of the function!
|
This appears SV-COMP'18 specific and not planned to be applied to the whole codebase (also flagged to not be merged and still requiring author cleanup, regression tests, etc.). If you believe this close is erroneous please reopen. |
|
@tautschnig is this still relevant for the current SV-COMPs? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge: this needs cleanup and review as well as regression tests.