Skip to content

Function-pointer removal performance fix #2227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 22, 2018
Merged

Function-pointer removal performance fix #2227

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8372862
function-pointer removal: Set the mode of a return symbol
tautschnig May 22, 2018
4f7fade
Cleanup: use symbolt::symbol_expr
tautschnig May 22, 2018
3b3dc71
Distinct names of return-value symbols
tautschnig May 22, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions src/goto-programs/remove_function_pointers.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,17 +233,18 @@ void remove_function_pointerst::fix_return_type(
code_type.return_type(), ns))
return;

const symbolt &function_symbol =
ns.lookup(to_symbol_expr(function_call.function()).get_identifier());

symbolt &tmp_symbol = get_fresh_aux_symbol(
code_type.return_type(),
id2string(function_call.source_location().get_function()),
"tmp_return_val",
"tmp_return_val_" + id2string(function_symbol.base_name),
function_call.source_location(),
irep_idt(),
function_symbol.mode,
symbol_table);

symbol_exprt tmp_symbol_expr;
tmp_symbol_expr.type()=tmp_symbol.type;
tmp_symbol_expr.set_identifier(tmp_symbol.name);
const symbol_exprt tmp_symbol_expr = tmp_symbol.symbol_expr();

exprt old_lhs=function_call.lhs();
function_call.lhs()=tmp_symbol_expr;
Expand Down