Skip to content

Fix two cbmc tests #2367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 19, 2018
Merged

Fix two cbmc tests #2367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4de4538
switch regression/cbmc/Typecast2 to preprocessed code
Jun 19, 2018
bcc3bef
make regression/cbmc/bounds_check1 independent of types used
Jun 19, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions regression/cbmc/Typecast2/main.c
View file
Open in desktop

This file was deleted.

7 changes: 7 additions & 0 deletions regression/cbmc/Typecast2/main.i
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
int main()
{
unsigned int i=2;
__CPROVER_assert(0l==(signed long int)(i - (unsigned int)2),
"difference of cast");
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this change necessary and/or beneficial?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When run on a 32-bit system, you would otherwise need a cross-compiler to 64-bit.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, of course, I'm sorry for having been dense. Yet it would be nice if such information were included in the commit message.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, now in commit message.

return 0;
}
2 changes: 1 addition & 1 deletion regression/cbmc/Typecast2/test.desc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
CORE
main.c
main.i
--no-propagation --64
^EXIT=0$
^SIGNAL=0$
Expand Down
12 changes: 6 additions & 6 deletions regression/cbmc/bounds_check1/test.desc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,12 @@ main.c
--bounds-check --pointer-check
^EXIT=10$
^SIGNAL=0$
\[\(signed long( long)? int\)i2\]: FAILURE
dest\[\(signed long( long)? int\)j2\]: FAILURE
payload\[\(signed long( long)? int\)[kl]2\]: FAILURE
\[\(.*\)i2\]: FAILURE
dest\[\(.*\)j2\]: FAILURE
payload\[\(.*\)[kl]2\]: FAILURE
\*\* 10 of 72 failed
--
^warning: ignoring
\[\(signed long( long)? int\)i\]: FAILURE
dest\[\(signed long( long)? int\)j\]: FAILURE
payload\[\(signed long( long)? int\)[kl]\]: FAILURE
\[\(.*\)i\]: FAILURE
dest\[\(.*\)j\]: FAILURE
payload\[\(.*\)[kl]\]: FAILURE