Skip to content

Add missing virtual destructor #2425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2018
Merged

Add missing virtual destructor #2425

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions src/goto-instrument/rw_set.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ class rw_set_baset
{
}

~rw_set_baset() {}
virtual ~rw_set_baset() = default;

struct entryt
{
Expand Down Expand Up @@ -136,8 +136,6 @@ class _rw_set_loct:public rw_set_baset
{
}

~_rw_set_loct() {}

protected:
value_setst &value_sets;
const goto_programt::const_targett target;
Expand Down Expand Up @@ -192,8 +190,6 @@ class rw_set_loct:public _rw_set_loct
{
compute();
}

~rw_set_loct() {}
};

// another producer, this time for entire functions
Expand All @@ -213,8 +209,6 @@ class rw_set_functiont:public rw_set_baset
compute_rec(function);
}

~rw_set_functiont() {}

protected:
const namespacet ns;
value_setst &value_sets;
Expand Down Expand Up @@ -258,8 +252,6 @@ class rw_set_with_trackt:public _rw_set_loct
compute();
}

~rw_set_with_trackt() {}

protected:
/* flag and variable in the expression, from which we dereference */
bool dereferencing;
Expand Down
2 changes: 2 additions & 0 deletions src/pointer-analysis/value_set.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,8 @@ class value_sett
{
}

virtual ~value_sett() = default;

static bool field_sensitive(
const irep_idt &id,
const typet &type,
Expand Down
2 changes: 2 additions & 0 deletions src/util/endianness_map.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ class endianness_mapt
{
}

virtual ~endianness_mapt() = default;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with @kroening that some classes should rather be made final, such as this one.


size_t map_bit(size_t bit) const
{
assert(bit<map.size());
Expand Down