-
Notifications
You must be signed in to change notification settings - Fork 273
Silence warnings about unused parameters [blocks: #2310] #2470
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm more ambivalent about these changes to silence Visual Studio compiler warnings that the other recent PR's on this topic. Would it be worth at least adding a // silence compiler warning
comment with each the new (void)
uses that have been added in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer this PR to #2468.
Note, that they are currently complementary: where I deemed the parameter named valuable I've added a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR failed Diffblue compatibility checks (cbmc commit: 5cabcea).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/77257469
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.
Common spurious failures:
- the cbmc commit has disappeared in the mean time (e.g. in a force-push)
- the author is not in the list of contributors (e.g. first-time contributors).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passed Diffblue compatibility checks (cbmc commit: a139223).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/78365264
As just said in #2468: @chrisr-diffblue, @peterschrammel I have created #2568 as a proposed amendment to the coding standard. |
Rebased, updated, comments added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR failed Diffblue compatibility checks (cbmc commit: dc2489d).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/78561014
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.
Common spurious failures:
- the cbmc commit has disappeared in the mean time (e.g. in a force-push)
- the author is not in the list of contributors (e.g. first-time contributors).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tautschnig, needs a rebase.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not opposed but I think that changes to the linter / clang-format / CI are a better way of approaching this sort of thing.
dc2489d
to
c894080
Compare
I don't think it's within the capabilities of a linter or formatter to detect those problems, but compilers would. Enabling this in CI is part of #2310, which this PR is factored out from. |
88917b5
to
35ba8ce
Compare
35ba8ce
to
c38112b
Compare
c38112b
to
ab6255b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️
Passed Diffblue compatibility checks (cbmc commit: ab6255b).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/90533681
ab6255b
to
ffb6f49
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫
This PR failed Diffblue compatibility checks (cbmc commit: ffb6f49).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/90581220
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.
Common spurious failures:
- the cbmc commit has disappeared in the mean time (e.g. in a force-push)
- the author is not in the list of contributors (e.g. first-time contributors).
The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.
ffb6f49
to
748533a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diffblue compatibility check is currently unavailable.
Please create manual bump.
(cbmc commit: 748533a).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/90847630
748533a
to
5e1fcb4
Compare
Their names are useful to understand the purpose of the function and/or are part of Doxygen documentation, and thus cannot be removed.
5e1fcb4
to
359b3b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✔️
Passed Diffblue compatibility checks (cbmc commit: 359b3b1).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/90955657
Their names are useful to understand the purpose of the function and/or are part
of Doxygen documentation, and thus cannot be removed.