Evaluate expressions that delimit GCC switch/case ranges #2490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
requested review from
kroening,
peterschrammel and
smowton
as code owners
allredj
reviewed
Jun 27, 2018
There was a problem hiding this comment.
Passed Diffblue compatibility checks (cbmc commit: 6ee96aa).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/77502401
kroening
reviewed
Jun 27, 2018
src/goto-programs/goto_convert.cpp
Outdated
| const auto lb = numeric_cast<mp_integer>(code.op0()); | ||
| const auto ub = numeric_cast<mp_integer>(code.op1()); | ||
| const auto lb = numeric_cast<mp_integer>(simplify_expr(code.op0(), ns)); | ||
| const auto ub = numeric_cast<mp_integer>(simplify_expr(code.op1(), ns)); | ||
|
|
There was a problem hiding this comment.
Should use make_constant(...)!
There was a problem hiding this comment.
Possibly so, but make_constant lives in the C type checker, and thus isn't available here.
Type casts may reasonably occur in here (and maybe also other expressions that evaluate to constants). The regression test addionally covers the case of enum values being used, which works fine (even without this change).
kroening
approved these changes
Jul 3, 2018
allredj
reviewed
Jul 3, 2018
There was a problem hiding this comment.
Passed Diffblue compatibility checks (cbmc commit: 15d4307).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/77961667
NathanJPhillips
added a commit
to NathanJPhillips/cbmc
that referenced
this pull request
Aug 22, 2018
f90ed9e Merge pull request diffblue#2515 from NathanJPhillips/feature/ignored-methods 4a12a29 Prevent crash when only instance of class is marked as an overlay 841313d Add ability to mark methods as ignored (not loaded) 0c20014 Merge pull request diffblue#2513 from tautschnig/clean 4c14354 Merge pull request diffblue#2490 from tautschnig/switch-range 72b92a4 Merge pull request diffblue#2471 from tautschnig/vs-non-static 1941c6c Merge pull request diffblue#2508 from tautschnig/skip-typecast a9e4ce9 Merge pull request diffblue#2512 from tautschnig/fix-typo 2be11f3 Make "clean" target in regression tests do full cleanup 97e9314 Do not hardcode tests.log as option -s <suffix> may be in use ad1f266 Fix typo seperated -> separated 15d4307 Evaluate expressions that delimit GCC switch/case ranges 770b779 Make skip_typecast widely available b4f5800 Merge pull request diffblue#2492 from NathanJPhillips/doc/get_writeable_symbol b58813b Merge pull request diffblue#2479 from thk123/bugfix/TG-3908/give-string-objects-names fd2f21e Use new method to set the name 190b485 Introduce method for getting the name of of java_class_type ffbb83f Merge pull request diffblue#2496 from diffblue/compilation-instructions2 594c2f2 unzip is needed on Debian, plus say how to build jbmc on Windows dabc169 Given string types an appropriate name 76eaf86 Doxygen comment on get_writeable_symbol 7191f23 Do not unnecessarily mark local variables static git-subtree-dir: cbmc git-subtree-split: f90ed9e
chrisr-diffblue
added a commit
to chrisr-diffblue/cbmc
that referenced
this pull request
Aug 24, 2018
chrisr-diffblue
added a commit
to chrisr-diffblue/cbmc
that referenced
this pull request
Aug 24, 2018
REVERT PR diffblue#2490 switch-range commit
chrisr-diffblue
pushed a commit
to chrisr-diffblue/cbmc
that referenced
this pull request
Aug 24, 2018
This reverts commit 86eed1d.
chrisr-diffblue
added a commit
to chrisr-diffblue/cbmc
that referenced
this pull request
Aug 24, 2018
…ert-revert-2490 Revert "REVERT PR diffblue#2490 switch-range commit"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type casts may reasonably occur in here (and maybe also other expressions that
evaluate to constants). The regression test addionally covers the case of enum
values being used, which works fine (even without this change).