replace_symbolt refactoring and stricter type checking #2723
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
requested review from
chrisr-diffblue,
kroening,
martin-cs,
peterschrammel,
pkesseli,
smowton and
thk123
as code owners
tautschnig
force-pushed
the
replace_symbol-cleanup
branch
3 times, most recently
from
0b1856d to
7f31123
Compare
tautschnig
force-pushed
the
replace_symbol-cleanup
branch
from
7f31123 to
e62fe87
Compare
tautschnig
force-pushed
the
replace_symbol-cleanup
branch
2 times, most recently
from
3247fdd to
03d003f
Compare
|
Further cleanup and refactoring based on feedback provided by @kroening - I think this is much cleaner and simpler now. Thanks a lot! |
kroening
approved these changes
Aug 17, 2018
tautschnig
force-pushed
the
replace_symbol-cleanup
branch
3 times, most recently
from
2e0d5c5 to
f4b6f23
Compare
peterschrammel
approved these changes
Aug 31, 2018
All such cases will have a symbol_exprt in the vicinity and thus use insert(symbol_exprt, exprt) instead.
Any such replacement would raise questions about type consistency. The code would also have required updating to include various tag types.
The derived class unchecked_replace_symbolt will not do any such type checking and is to be used in all cases where types are expected to change or no type checking can be performed.
tautschnig
force-pushed
the
replace_symbol-cleanup
branch
from
f4b6f23 to
e8ac23c
Compare
tautschnig
force-pushed
the
replace_symbol-cleanup
branch
from
e8ac23c to
9b62514
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first three commits are in separate pull requests already (#2720, #2721, #2722). The last three commits are actually new. Please provide feedback whether this design is acceptable/better (@kroening in particular).