Skip to content

Function-pointer remvoval: print human-friendly debug messages #2727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 14, 2018
Merged

Function-pointer remvoval: print human-friendly debug messages #2727

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/goto-programs/remove_const_function_pointers.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,15 +12,19 @@ Author: Thomas Kiley, [email protected]
#include "remove_const_function_pointers.h"

#include <util/arith_tools.h>
#include <util/format_expr.h>
#include <util/simplify_expr.h>
#include <util/std_expr.h>
#include <util/symbol_table.h>

#include "goto_functions.h"

#define LOG(message, irep) \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is changed to multiple statements it should be in a block, otherwise it'll break in strange ways when doing something like if(something) LOG(something_else, e).

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, thanks for picking this up!

debug() << "Case " << __LINE__ << " : " << message << "\n" \
<< irep.pretty() << eom;
do { \
debug().source_location = irep.source_location(); \
debug() << message << ": " << format(irep) << eom; \
} \
while(0)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Slight preference for false instead of 0 here; But we already use 0 in other places for this sort of construct so either is fine by me.


/// To take a function call on a function pointer, and if possible resolve it to
/// a small collection of possible values.
Expand Down