Skip to content

Make generate_nondet_switch available in CBMC #2872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mgudemann
Copy link
Contributor

This was limited to JBMC before, it now takes the mode explicitely and is moved to CBMC src/util

@mgudemann mgudemann force-pushed the feature/generalize_nondet_switch branch from 0937077 to 3d8cb25 Compare August 31, 2018 10:01
Copy link

@majakusber majakusber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Matthias Güdemann added 2 commits August 31, 2018 15:35
Make mode a parameter instead of assuming `ID_java`.
Make nondet.{h,cpp} generally available for CBMC.
@mgudemann mgudemann force-pushed the feature/generalize_nondet_switch branch from 3d8cb25 to 30b44f6 Compare August 31, 2018 13:36
@peterschrammel peterschrammel changed the title Make generate_nondet_switch avilable in CBMC Make generate_nondet_switch available in CBMC Aug 31, 2018
@@ -37,21 +36,18 @@ symbol_exprt generate_nondet_int(
const int64_t max_value,
const std::string &name_prefix,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please document that name_prefix must be id2string(function_id) (or rename it accordingly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@tautschnig tautschnig merged commit 51eed48 into diffblue:develop Sep 3, 2018
@mgudemann mgudemann deleted the feature/generalize_nondet_switch branch September 3, 2018 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants