Skip to content

boolbvt: convert_with now does struct_tag and union_tag types #3084

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2018

Conversation

kroening
Copy link
Member

@kroening kroening commented Oct 2, 2018

  • Each commit message has a non-empty body, explaining why the change was made.
  • My contribution is formatted in line with CODING_STANDARD.md.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link
Collaborator

@tautschnig tautschnig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, but how did you notice? Do we know this is the last one?

@kroening
Copy link
Member Author

kroening commented Oct 2, 2018

@tautschnig There are currently a lot of bugs like this one hidden behind the fact that symbol types and struct and union tags are expanded during symbolic simulation.

Once we stop that expansion we should see these.

@tautschnig
Copy link
Collaborator

I was guessing as much; as a reviewer, it's would be nice to have some info like "fixes N tests when not expanding tags during symex." (And maybe "Y tests remaining to be debugged.")

Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passed Diffblue compatibility checks (cbmc commit: dbec311).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/86674798

@kroening kroening merged commit 0e695d0 into develop Oct 3, 2018
@kroening kroening deleted the boolbvt_convert_with_tag_types branch October 3, 2018 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants