-
Notifications
You must be signed in to change notification settings - Fork 273
Re-try Minisat download (up to two times) in case it fails #3139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's a fudge but ... I can see why it's useful.
src/Makefile
Outdated
@@ -89,7 +89,12 @@ TAR = tar | |||
|
|||
minisat2-download: | |||
@echo "Downloading Minisat 2.2.1" | |||
@$(DOWNLOADER) http://ftp.debian.org/debian/pool/main/m/minisat2/minisat2_2.2.1.orig.tar.gz | |||
@for i in `seq 1 3` ; do \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nitpick: prefer $(cmd)
to backticks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see the desire to have this, but I have the feeling it's possibly implemented in the wrong place... Would this actually be better done in the .travis.yml, etc? As it stands this also does nothing for CMake based builds, but I appreciate that they handle the minisat download in a different way which is probably more annoying to fix up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passed Diffblue compatibility checks (cbmc commit: f03a2ca).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/87498958
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with @chrisr-diffblue that this should be done in .travis.yml. travis_retry cmd
is probably the way to do it: https://docs.travis-ci.com/user/common-build-problems/#timeouts-installing-dependencies
My reason for not putting it in the Travis config file was to avoid duplication: the very same code would also go in the CodeBuild specs for both Linux and Windows and (at least in my use case) a number of build rules living outside the repository. All of which currently invoke |
f03a2ca
to
b223bfe
Compare
Running in CI we do see transient network access errors from time to time, which should not result in task failures (as long as they are genuinely transient). For CMake we could do the same once upgrading to >= 3.7 (else it would be very clumsy to implement).
b223bfe
to
cc4347d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR failed Diffblue compatibility checks (cbmc commit: b223bfe).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/87819761
Status will be re-evaluated on next push.
Please contact @peterschrammel, @thk123, or @allredj for support.
Common spurious failures:
- the cbmc commit has disappeared in the mean time (e.g. in a force-push)
- the author is not in the list of contributors (e.g. first-time contributors).
The incompatibility may have been introduced by an earlier PR. In that case merging this
PR should be avoided unless it fixes the current incompatibility.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passed Diffblue compatibility checks (cbmc commit: cc4347d).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/87820352
Running in CI we do see transient network access errors from time to time, which
should not result in task failures (as long as they are genuinely transient).