JBMC: support list-symbols #3207
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smowton
requested review from
cesaro,
cristina-david,
kroening,
peterschrammel,
pkesseli and
tautschnig
as code owners
kroening
approved these changes
Oct 20, 2018
peterschrammel
approved these changes
Oct 20, 2018
There was a problem hiding this comment.
Clang-format is complaining: https://travis-ci.org/diffblue/cbmc/jobs/443779256#L547
jbmc/src/jbmc/jbmc_parse_options.h
Outdated
| OPT_SHOW_CLASS_HIERARCHY \ | ||
| "(show-loops)" \ | ||
| "(show-symbol-table)(show-parse-tree)" \ | ||
| "(show-symbol-table)(list-symbols)(show-parse-tree)" \ |
There was a problem hiding this comment.
Preferably put on separate lines.
tautschnig
requested changes
Oct 20, 2018
The plain-text mode correctly prints only names and types; with --json-ui until now we accidentally printed the symbol's value as well, which should only happen with --show-symbol-table.
No functional changes
smowton
force-pushed
the
smowton/feature/jbmc-list-symbols
branch
from
8cd5034 to
1891dcf
Compare
|
@tautschnig oops, was from a subtree cherry-pick. Fixed. |
smowton
force-pushed
the
smowton/feature/jbmc-list-symbols
branch
from
1891dcf to
d61ad5b
Compare
tautschnig
approved these changes
Oct 22, 2018
smowton
force-pushed
the
smowton/feature/jbmc-list-symbols
branch
from
d61ad5b to
74c9ff9
Compare
allredj
reviewed
Oct 22, 2018
There was a problem hiding this comment.
Passed Diffblue compatibility checks (cbmc commit: 74c9ff9).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/88760621
This mirrors the support already present in cbmc
smowton
force-pushed
the
smowton/feature/jbmc-list-symbols
branch
from
74c9ff9 to
87581eb
Compare
allredj
reviewed
Oct 23, 2018
There was a problem hiding this comment.
Passed Diffblue compatibility checks (cbmc commit: 87581eb).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/88799241
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
--list-symbolsargument to JBMC (matching existing argument in CBMC), and fix the accidental inclusion of the symbol value in the JSON output even inlistmode.