Skip to content

static_show_domain doesn't determine SAFE/UNSAFE #3213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2018
Merged

static_show_domain doesn't determine SAFE/UNSAFE #3213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions jbmc/src/janalyzer/janalyzer_parse_options.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -588,8 +588,8 @@ int janalyzer_parse_optionst::perform_analysis(const optionst &options)
bool result = true;
if(options.get_bool_option("show"))
{
result = static_show_domain(
goto_model, *analyzer, options, out);
static_show_domain(goto_model, *analyzer, options, out);
return CPROVER_EXIT_SUCCESS;
}
else if(options.get_bool_option("verify"))
{
Expand Down
8 changes: 4 additions & 4 deletions src/goto-analyzer/goto_analyzer_parse_options.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -621,13 +621,13 @@ int goto_analyzer_parse_optionst::perform_analysis(const optionst &options)

// Perform the task
status() << "Performing task" << eom;

bool result = true;

if(options.get_bool_option("show"))
{
result = static_show_domain(goto_model,
*analyzer,
options,
out);
static_show_domain(goto_model, *analyzer, options, out);
return CPROVER_EXIT_SUCCESS;
}
else if(options.get_bool_option("verify"))
{
Expand Down
5 changes: 1 addition & 4 deletions src/goto-analyzer/static_show_domain.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,7 @@ Author: Martin Brain, [email protected]
/// \param ai: the abstract interpreter after it has been run to fix point
/// \param options: the parsed user options
/// \param out: output stream for the printing
/// \return: false on success with the domain printed to out
bool static_show_domain(
void static_show_domain(
const goto_modelt &goto_model,
const ai_baset &ai,
const optionst &options,
Expand Down Expand Up @@ -48,6 +47,4 @@ bool static_show_domain(
// 'text' or console output
ai.output(goto_model, out);
}

return false;
}
2 changes: 1 addition & 1 deletion src/goto-analyzer/static_show_domain.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ class goto_modelt;
class message_handlert;
class optionst;

bool static_show_domain(
void static_show_domain(
const goto_modelt &,
const ai_baset &,
const optionst &,
Expand Down