Skip to content

Use more specific return type instead of generic codet/exprt #3274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2018

Conversation

tautschnig
Copy link
Collaborator

If functions can only ever return a single kind of codet/exprt, there is no need
to use the generic codet/exprt and std::move.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig self-assigned this Nov 5, 2018
If functions can only ever return a single kind of codet/exprt, there is no need
to use the generic codet/exprt and std::move.
@tautschnig tautschnig merged commit b55b44d into diffblue:develop Nov 5, 2018
@tautschnig tautschnig deleted the precise_return_type branch November 5, 2018 17:49
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 65efd76).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/90305411

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants