Skip to content

C front-end: cleanup label statement type checking #3277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 6, 2018
Merged

C front-end: cleanup label statement type checking #3277

merged 1 commit into from
Nov 6, 2018

Conversation

tautschnig
Copy link
Collaborator

The code used to contain a loop that had no effect. The regression test confirms
that we properly handle nested labels anyway.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig requested a review from kroening as a code owner November 5, 2018 15:03
@tautschnig tautschnig mentioned this pull request Nov 5, 2018
Merged
3 tasks
@kroening
Copy link
Member

kroening commented Nov 5, 2018

The newly added test needs to be excluded from the SMT2 tests (this will become less painful once the SMT2 backend is fixed).

@kroening
Copy link
Member

kroening commented Nov 5, 2018

Meaning I'd simply wait for that.

@tautschnig tautschnig assigned tautschnig and unassigned kroening Nov 5, 2018
allredj
allredj reviewed Nov 5, 2018
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: b929839).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/90323327

thk123
thk123 approved these changes Nov 6, 2018
View reviewed changes
src/ansi-c/c_typecheck_code.cpp
else
new_ops.move(code_op);
if(code_op.is_not_nil())
new_ops.add(std::move(code_op));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is nice the code is a lot simpler - but we now don't check the operands size - is this a problem?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Type checking of labels is done elsewhere, I'd say this should be done over there.

@tautschnig
C front-end: cleanup label statement type checking
e430c29 
The code used to contain a loop that had no effect. The regression test confirms
that we properly handle nested labels anyway.
allredj
allredj reviewed Nov 6, 2018
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: e430c29).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/90466076

@tautschnig tautschnig merged commit 8730366 into diffblue:develop Nov 6, 2018
@tautschnig tautschnig deleted the nested-labels branch November 6, 2018 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allredj allredj allredj left review comments

@thk123 thk123 thk123 approved these changes

@kroening kroening kroening approved these changes

@peterschrammel peterschrammel peterschrammel approved these changes

@forejtv forejtv Awaiting requested review from forejtv

Assignees

@thk123 thk123

@peterschrammel peterschrammel

@forejtv forejtv

Labels
C Front End cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tautschnig @kroening @thk123 @peterschrammel @allredj @forejtv