Skip to content

Do not shadow function parameter code [blocks: #2310] #3359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 11, 2018
Merged

Do not shadow function parameter code [blocks: #2310] #3359

merged 1 commit into from
Nov 11, 2018

Conversation

tautschnig
Copy link
Collaborator

Name the local variable decl (a declaration) instead.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig requested a review from kroening as a code owner November 11, 2018 14:26
@tautschnig
Do not shadow function parameter code
584c878 
Name the local variable decl (a declaration) instead.
@tautschnig tautschnig assigned tautschnig and unassigned kroening Nov 11, 2018
allredj
allredj reviewed Nov 11, 2018
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 584c878).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/90992466

@tautschnig tautschnig merged commit 62280d2 into diffblue:develop Nov 11, 2018
@tautschnig tautschnig deleted the vs-shadow-8 branch November 11, 2018 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allredj allredj allredj left review comments

@kroening kroening kroening approved these changes

@peterschrammel peterschrammel peterschrammel approved these changes

Assignees

@tautschnig tautschnig

Labels
blocker cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tautschnig @kroening @peterschrammel @allredj