Skip to content

Avoid implicit conversion to bool and actually use return value [blocks: #2310] #3373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 12, 2018

Conversation

tautschnig
Copy link
Collaborator

The function was declared to return a bool (that was never read) and did so from
a function call returning an int. Make conversion explicit and actually test on
that return value.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

The function was declared to return a bool (that was never read) and did so from
a function call returning an int. Make conversion explicit and actually test on
that return value.
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: d8f97c1).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/91036753

@tautschnig tautschnig merged commit 9545b12 into diffblue:develop Nov 12, 2018
@tautschnig tautschnig deleted the vs-bool-osx branch November 12, 2018 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants