Skip to content

Do not shadow "resolved" [blocks: #2310] #3377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 12, 2018
Merged

Do not shadow "resolved" [blocks: #2310] #3377

merged 1 commit into from
Nov 12, 2018

Conversation

tautschnig
Copy link
Collaborator

The values refer to different invocations of the resolving attempt.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig
Do not shadow "resolved"
781c9ba 
The values refer to different invocations of the resolving attempt.
allredj
allredj reviewed Nov 12, 2018
View reviewed changes
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 781c9ba).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/91044884

@tautschnig tautschnig merged commit 0180967 into diffblue:develop Nov 12, 2018
@tautschnig tautschnig deleted the vs-shadow-13 branch November 12, 2018 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@allredj allredj allredj left review comments

@smowton smowton smowton approved these changes

@owen-mc-diffblue owen-mc-diffblue owen-mc-diffblue approved these changes

@kroening kroening Awaiting requested review from kroening kroening is a code owner

@peterschrammel peterschrammel Awaiting requested review from peterschrammel peterschrammel is a code owner

@pkesseli pkesseli Awaiting requested review from pkesseli

Assignees

@smowton smowton

@kroening kroening

@peterschrammel peterschrammel

@pkesseli pkesseli

Labels
blocker cleanup
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@tautschnig @smowton @allredj @owen-mc-diffblue @kroening @peterschrammel @pkesseli