Skip to content

Replace side effects expressions inside address_of [blocks: #4471] #4470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 1, 2019

Conversation

tautschnig
Copy link
Collaborator

The C++ front-end may generate expressions that take the address of side
effects, such as temporary objects or assignments, when a reference is
taken. These side effects need to be replaced, just as is done outside
address_of expressions.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

The C++ front-end may generate expressions that take the address of side
effects, such as temporary objects or assignments, when a reference is
taken. These side effects need to be replaced, just as is done outside
address_of expressions.
@tautschnig tautschnig changed the title Replace side effects expressions inside address_of Replace side effects expressions inside address_of [blocks: #4471] Mar 31, 2019
Copy link
Contributor

@allredj allredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✔️
Passed Diffblue compatibility checks (cbmc commit: 888e290).
Build URL: https://travis-ci.com/diffblue/test-gen/builds/106489432

@kroening kroening merged commit ff128a6 into diffblue:develop Apr 1, 2019
@tautschnig tautschnig deleted the c++-side-effects branch April 1, 2019 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants