Skip to content

Refine-arrays: work with refine-strings #5245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

smowton
Copy link
Contributor

@smowton smowton commented Feb 26, 2020

Trivial fix to allow running the string solver with --refine-arrays. Doesn't seem to help much when the index set is large, but at least this means we don't ignore --refine-strings when --refine-arrays is passed.

@codecov-io
Copy link

Codecov Report

Merging #5245 into develop will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #5245      +/-   ##
===========================================
+ Coverage    67.43%   67.43%   +<.01%     
===========================================
  Files         1162     1162              
  Lines        95620    95622       +2     
===========================================
+ Hits         64477    64479       +2     
  Misses       31143    31143
Flag Coverage Δ
#cproversmt2 42.59% <100%> (ø) ⬆️
#regression 63.96% <100%> (ø) ⬆️
#unit 31.89% <100%> (ø) ⬆️
Impacted Files Coverage Δ
src/goto-checker/solver_factory.cpp 69.28% <100%> (+0.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 06d473f...d4b984f. Read the comment docs.

@smowton smowton merged commit 5568f64 into diffblue:develop Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants