Miniz support

[mgudemann]

this adds basic support for miniz a public domain zlib compatible compression/decompression library.
Integration would remove dependency on libzip/zlib.

[tautschnig]

That's great! It might be better to refer to https://github.com/richgel999/miniz as code.google.com is in archive-only mode. (Not that miniz would have seen any actual updates, but at least there is active participation and forking, such as https://github.com/uroni/miniz).

[mgudemann]

thanks for the pointer, I hadn't seen Rich Geldreich's repo on github, only independent ones.

There's currently some warnings which make building with -Werror fail. Should we try minmizing to the bare necessities, i.e, extracting files from zip/jar?

[tautschnig]

Have you merged various improvements from the forks? The "uroni" fork mentions http://www.tenacioussoftware.com/miniz_v116_beta_r1.7z which may be important bug fixes.

On your question: If you start modifying the code, you might as well strip it down to the bare minimum.

[mgudemann]

no I have used v115_r4 the uroni fork seems interesting. On the other hand, it's MIT licensed, not public domain, is this ok in CBMC? ​

[tautschnig]

In my understanding MIT is hardly different from public-domain, and in particular it is more liberal than BSD. So we should be good to use even the uroni fork as basis, should this be deemed useful.

[mgudemann]

ok, I'll wait for @kroening 's comment on this, whether we will do this and which version to use

the uroni patches seem to get (better?) ZIP64 support and a faster CRC32 with lookup tables. The main difference from PD to MIT is probably the obligation to include the copyright/license.
Currently MacOS builds fail (due to XXX64 calls for fseeko, stat etc.) so cannot be merged in current state anyway.

[kroening]

MIT License would be good, and this would make the build perhaps more robust.
There is also hope that this will build on Windows.
Can you please rebase?

[kroening]

Why is iostream needed?

[mgudemann]

it's not, this was just for debugging / proof of concept, I will add the MIT-licensed "uroni" version and clean this up

[mgudemann]

cleanup on-going, windows build on Appveyor works

[mgudemann]

cleaned-up version, uses https://github.com/uroni/miniz
I ran Jamie's sed output script on the added files, but there's still many style errors, most are "line too long"

[mgudemann]

linter is still unhappy, but build/test on Linux/MacOS works, build on Windows as well

[kroening]

Seems ready to go after rebase.

[mgudemann]

rebase done