Skip to content

Visual Studio 16.8 has different floating point precision #5613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2020

Conversation

tautschnig
Copy link
Collaborator

GitHub action runners now feature Visual Studio 16.8.1 (previously:
16.7). According to its STL changelog, this update includes the
following change:

microsoft/STL#1173 (review)

Therefore update the unit test to expect 13 trailing zeros.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

GitHub action runners now feature Visual Studio 16.8.1 (previously:
16.7). According to its STL changelog, this update includes the
following change:

microsoft/STL#1173 (review)

Therefore update the unit test to expect 13 trailing zeros for MSVC
version >= 19.28.
@codecov
Copy link

codecov bot commented Nov 18, 2020

Codecov Report

Merging #5613 (967383c) into develop (299307b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #5613   +/-   ##
========================================
  Coverage    69.33%   69.33%           
========================================
  Files         1241     1241           
  Lines       100424   100424           
========================================
  Hits         69625    69625           
  Misses       30799    30799           
Flag Coverage Δ
cproversmt2 43.09% <ø> (ø)
regression 66.23% <ø> (ø)
unit 32.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 299307b...d5912ec. Read the comment docs.

@tautschnig tautschnig merged commit 4144414 into diffblue:develop Nov 19, 2020
@tautschnig tautschnig deleted the visual-studio-16.8 branch November 19, 2020 10:07
@martin-cs
Copy link
Collaborator

Changes like this make me despair for any kind of repeatable or cross-platform floating-point behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants