-
Notifications
You must be signed in to change notification settings - Fork 277
Automatically create release tags via GitHub actions #5649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #5649 +/- ##
========================================
Coverage 69.44% 69.44%
========================================
Files 1243 1243
Lines 100612 100612
========================================
Hits 69875 69875
Misses 30737 30737
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
850eb25
to
84da40f
Compare
- name: Bump version and push tag | ||
uses: anothrNick/[email protected] | ||
env: | ||
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you checked if the default GITHUB_TOKEN
has the rights to create a tag? It not being allowed to do some things is something that has bitten me in the past, that's why I’m asking.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call out. I don't know whether this works, but also I'm not sure how to figure it out other than trying it out? (It seems safe to do so: in the worst case, it does not create a tag, and we'd have to go back to the previous, manual approach.)
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
DEFAULT_BUMP: none | ||
RELEASE_BRANCHES: develop | ||
VERBOSE: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this read the latest version from the existing tags?
If not we may need INITIAL_VERSION too:
INITIAL_VERSION (optional) - Set initial version before bump. Default 0.0.0.
Probably something like: INITIAL_VERSION: 5.20.1
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Supposedly the bash script behind this GitHub action does check for existing tags. But it may be worth flipping DRY_RUN
back on to make sure this does actually work as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have now added a commit to keep in in DRY_RUN
mode.
A further comment: we should likely wait for anothrNick/github-tag-action#95 to be merged to maintain the |
35a18c1
to
2bffaaf
Compare
Release tags are now created automatically when including an indicator (see updated documentation) in the commit message.
We should first make sure this actually works on this repository before enabling it in production.
2bffaaf
to
5ad6803
Compare
Hi Michael, I'd love to get this in and experiment with this a bit - it would save us quite a bit of time! Are you happy to take this forward (rebase on *: (I'll close this PR and make a new one, but |
Closing: automatic tagging won't save much time as the tag can be produced at the same time as publishing the changelog. |
The action is currently marked as DRY_RUN: true to perform testing, andEdit: I have performed testing in my fork (see https://github.com/tautschnig/cbmc/runs/1533820084), and am thus inclined to immediately enable this over here.will be enabled in a subsequent PR.