[smt2_convt] Fix invalid and NULL pointer handling #6040
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SaswatPadhi
added
SMT Backend Interface
bugfix
aws
SaswatPadhi
requested review from
allredj,
kroening,
martin-cs,
peterschrammel and
romainbrenguier
as code owners
SaswatPadhi
force-pushed
the
memset_null_fix
branch
4 times, most recently
from
171876f to
1bedd70
Compare
Codecov Report
@@ Coverage Diff @@
## develop #6040 +/- ##
========================================
Coverage 74.13% 74.13%
========================================
Files 1444 1444
Lines 157442 157418 -24
========================================
- Hits 116720 116707 -13
+ Misses 40722 40711 -11
Continue to review full report at Codecov.
|
tautschnig
reviewed
Apr 16, 2021
CBMC crashed on SMT2 conversion of pointer arithmetic on NULL and other kinds of invalid pointers. This change fixes the encoding of pointer arithmetic on invalid pointers.
SaswatPadhi
force-pushed
the
memset_null_fix
branch
from
1bedd70 to
aa04475
Compare
tautschnig
approved these changes
Apr 16, 2021
The SMT conversion routines crashed on encoding of comparisons over invalid pointers. This change fixes this behavior by ignoring comparisons against invalid pointers.
SaswatPadhi
force-pushed
the
memset_null_fix
branch
from
aa04475 to
7663a57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6022.
Several SMT2 conversion functions used to crash on
NULLpointers and other kinds of invalid pointers. This change fixes the handling of NULL pointers at several locations.Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/My commit message includes data points confirming performance improvements (if claimed).White-space or formatting changes outside the feature-related changed lines are in commits of their own.