Pointer subtraction was fixed in 3acdb52dd

[tautschnig]

The invariant failure was caused by a bug in handling pointer
subtraction, which was fixed in 3acdb52. The test also wrongly assumed
verification would succeed, which is not correct for *p, which is out
of bounds.

Fixes: #5328

• Each commit message has a non-empty body, explaining why the change was made.
• n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
• n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
• Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
• n/a My commit message includes data points confirming performance improvements (if claimed).
• My PR is restricted to a single feature or bugfix.
• n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

[codecov]

Codecov Report

Merging #6044 (e94daaa) into develop (5b30b06) will increase coverage by 0.22%.
The diff coverage is 60.86%.

@@             Coverage Diff             @@
##           develop    #6044      +/-   ##
===========================================
+ Coverage    74.13%   74.35%   +0.22%     
===========================================
  Files         1444     1444              
  Lines       157415   157448      +33     
===========================================
+ Hits        116702   117076     +374     
+ Misses       40713    40372     -341     

Impacted Files	Coverage Δ
src/solvers/smt2/smt2_conv.h	100.00% <ø> (ø)
src/solvers/smt2/smt2_conv.cpp	60.30% <52.94%> (-0.07%)	⬇️
src/solvers/smt2/smt2_solver.cpp	83.11% <65.51%> (-2.25%)	⬇️
src/big-int/bigint.cc	88.85% <0.00%> (+0.74%)	⬆️
src/util/irep_serialization.cpp	92.66% <0.00%> (+1.83%)	⬆️
src/util/expr_initializer.cpp	83.55% <0.00%> (+4.60%)	⬆️
src/ansi-c/literals/convert_integer_literal.cpp	90.58% <0.00%> (+5.88%)	⬆️
src/util/ui_message.cpp	85.53% <0.00%> (+7.54%)	⬆️
src/ansi-c/c_typecheck_initializer.cpp	74.57% <0.00%> (+12.52%)	⬆️
src/util/xml.cpp	72.97% <0.00%> (+14.18%)	⬆️
... and 1 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b233b7e...e94daaa. Read the comment docs.