Skip to content

Add various formatters #6092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 9, 2021
Merged

Add various formatters #6092

merged 5 commits into from
May 9, 2021

Conversation

kroening
Copy link
Member

@kroening kroening commented May 8, 2021

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@kroening kroening changed the title Add various expression formatters Add various formatters May 8, 2021
@kroening kroening marked this pull request as ready for review May 8, 2021 13:00
@codecov
Copy link

codecov bot commented May 8, 2021

Codecov Report

Merging #6092 (4c14789) into develop (823e1b2) will increase coverage by 0.07%.
The diff coverage is 96.96%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6092      +/-   ##
===========================================
+ Coverage    74.45%   74.52%   +0.07%     
===========================================
  Files         1447     1447              
  Lines       157746   157808      +62     
===========================================
+ Hits        117453   117610     +157     
+ Misses       40293    40198      -95     
Impacted Files Coverage Δ
jbmc/src/janalyzer/janalyzer_main.cpp 100.00% <ø> (ø)
jbmc/src/java_bytecode/assignments_from_json.cpp 97.26% <ø> (ø)
jbmc/src/java_bytecode/ci_lazy_methods.cpp 99.47% <ø> (ø)
jbmc/src/java_bytecode/ci_lazy_methods.h 100.00% <ø> (ø)
jbmc/src/java_bytecode/ci_lazy_methods_needed.cpp 98.24% <ø> (ø)
jbmc/src/java_bytecode/ci_lazy_methods_needed.h 100.00% <ø> (ø)
jbmc/src/java_bytecode/convert_java_nondet.cpp 81.15% <ø> (ø)
...java_bytecode/create_array_with_type_intrinsic.cpp 97.67% <ø> (ø)
jbmc/src/java_bytecode/expr2java.cpp 86.61% <ø> (ø)
jbmc/src/java_bytecode/expr2java.h 100.00% <ø> (ø)
... and 264 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55d32b5...4c14789. Read the comment docs.

Copy link
Collaborator

@tautschnig tautschnig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just updates to scripts/expected_doxygen_warnings.txt left to be done.

@tautschnig
Copy link
Collaborator

Wishlist item: perhaps you could squeeze a formatter for dereference_exprt into this PR as well?

kroening added 4 commits May 9, 2021 17:09
This adds a type formatter for function types, using Unicode for the
cross-product, if applicable.
This adds an expression formatter for pointer-typed constants.
This adds a formatter for string constants, without using any particular
scheme for escaping.
This adds the obvious formatter for applications of mathematical functions.
@kroening kroening force-pushed the add_expression_formatters branch from c2a0090 to afd1391 Compare May 9, 2021 16:10
This adds a formatter for dereference expressions that uses a C-style syntax.
@kroening kroening force-pushed the add_expression_formatters branch from a174f43 to 4c14789 Compare May 9, 2021 16:21
@kroening kroening merged commit 72076ab into develop May 9, 2021
@kroening kroening deleted the add_expression_formatters branch May 9, 2021 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants