Skip to content

remove an include from goto-programs/goto_program.h #6312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 31, 2021

Conversation

kroening
Copy link
Member

@kroening kroening commented Aug 23, 2021

This removes an unneeded include from goto-programs/goto_program.h, which is
widely used.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • n/a Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • n/a My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

This removes an unneeded include from goto-programs/goto_program.h, which is
widely used.
@codecov
Copy link

codecov bot commented Aug 23, 2021

Codecov Report

Merging #6312 (848d182) into develop (493bc71) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6312      +/-   ##
===========================================
- Coverage    75.98%   75.98%   -0.01%     
===========================================
  Files         1512     1512              
  Lines       163456   163459       +3     
===========================================
- Hits        124204   124203       -1     
- Misses       39252    39256       +4     
Impacted Files Coverage Δ
...mc/src/java_bytecode/java_local_variable_table.cpp 95.22% <ø> (ø)
...nit/java-testing-utils/require_goto_statements.cpp 82.82% <ø> (ø)
...de/java_trace_validation/java_trace_validation.cpp 100.00% <ø> (ø)
src/analyses/local_bitvector_analysis.cpp 75.14% <ø> (ø)
src/analyses/local_cfg.h 75.00% <ø> (ø)
src/analyses/local_safe_pointers.cpp 81.55% <ø> (ø)
src/analyses/local_safe_pointers.h 100.00% <ø> (ø)
src/analyses/uncaught_exceptions_analysis.cpp 92.77% <ø> (ø)
...yses/variable-sensitivity/abstract_environment.cpp 95.02% <ø> (ø)
...riable-sensitivity/variable_sensitivity_domain.cpp 89.44% <ø> (ø)
... and 74 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4369b6...848d182. Read the comment docs.

Copy link
Collaborator

@martin-cs martin-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@martin-cs martin-cs removed their assignment Aug 31, 2021
Copy link
Collaborator

@tautschnig tautschnig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the clean-up, but I do have concerns about the code we had in the first place.

@tautschnig tautschnig assigned kroening and unassigned tautschnig Aug 31, 2021
@kroening kroening merged commit a023d0f into develop Aug 31, 2021
@kroening kroening deleted the goto_program_include branch August 31, 2021 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants