Skip to content

Byte extract lowering: refactor lowering of arrays/vectors [blocks: #6488] #6486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

tautschnig
Copy link
Collaborator

Both cases had some of the same code. Refactor those cases out of an
already-too-big function into one of its own.

This is in preparation of further changes to this code to support some
of the cases currently deemed unsupported.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Both cases had some of the same code. Refactor those cases out of an
already-too-big function into one of its own.

This is in preparation of further changes to this code to support some
of the cases currently deemed unsupported.
@tautschnig tautschnig changed the title Byte extract lowering: refactor lowering of arrays/vectors Byte extract lowering: refactor lowering of arrays/vectors [blocks: #6488] Nov 29, 2021
@codecov
Copy link

codecov bot commented Nov 29, 2021

Codecov Report

Merging #6486 (bee3b76) into develop (5bf69a3) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #6486      +/-   ##
===========================================
- Coverage    76.04%   76.03%   -0.01%     
===========================================
  Files         1546     1546              
  Lines       165521   165511      -10     
===========================================
- Hits        125864   125854      -10     
  Misses       39657    39657              
Impacted Files Coverage Δ
src/solvers/lowering/byte_operators.cpp 92.14% <100.00%> (-0.08%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 65cd7eb...bee3b76. Read the comment docs.

@martin-cs
Copy link
Collaborator

I think this is fine to merge even though there is a minor drop in coverage.

@tautschnig
Copy link
Collaborator Author

I think this is fine to merge even though there is a minor drop in coverage.

Fair, but I'm patting myself on the back for 100% patch coverage 😇

@tautschnig tautschnig merged commit 000f528 into diffblue:develop Dec 1, 2021
@tautschnig tautschnig deleted the refactor-byte-extract-arrays-vector branch December 1, 2021 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants