Fix linking in case of function type conflict #6547
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
requested review from
chrisr-diffblue and
kroening
as code owners
tautschnig
force-pushed
the
pointer-parameter-type-conflict
branch
3 times, most recently
from
c0aa8f5 to
068a9d8
Compare
Codecov ReportBase: 77.92% // Head: 77.96% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #6547 +/- ##
===========================================
+ Coverage 77.92% 77.96% +0.03%
===========================================
Files 1616 1616
Lines 186814 186855 +41
===========================================
+ Hits 145580 145675 +95
+ Misses 41234 41180 -54
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
tautschnig
force-pushed
the
pointer-parameter-type-conflict
branch
from
068a9d8 to
3b73b4d
Compare
chris-ryder
approved these changes
Feb 5, 2022
tautschnig
force-pushed
the
pointer-parameter-type-conflict
branch
4 times, most recently
from
c0a3df4 to
3a2bbfc
Compare
tautschnig
force-pushed
the
pointer-parameter-type-conflict
branch
2 times, most recently
from
7cc5253 to
0e8fb79
Compare
tautschnig
force-pushed
the
pointer-parameter-type-conflict
branch
from
0e8fb79 to
1e1426f
Compare
tautschnig
force-pushed
the
pointer-parameter-type-conflict
branch
2 times, most recently
from
9f54262 to
92fc2e3
Compare
tautschnig
force-pushed
the
pointer-parameter-type-conflict
branch
from
92fc2e3 to
d56bedf
Compare
We previously just reported pointer type conflicts without elaborating what the exact difference was. To produce type-consistent goto programs, we chose to use the type that the definition had, but lacked any test that doing so would actually result in a program that can be analysed successfully. This commit fixes bugs in the code producing diagnostics, enables diagnostics for the case of pointer type conflicts, and adds a test to demonstrate that we successfully analyse programs after type conflict resolution. Despite this, however, inconsistencies in the goto program remain: the call types still need fixing up. Fixes: diffblue#198
The linker already accepted a number of type mismatches for function declarations, but did not actually modify the goto functions to reflect these type mismatches, just the type information in the symbol table was updated. These changes enable support for conflicts on function return types, which are now resolved by introducing type casts.
tautschnig
force-pushed
the
pointer-parameter-type-conflict
branch
from
d56bedf to
39e7078
Compare
kroening
approved these changes
Oct 10, 2022
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already almost did the right thing, but were failing to update types at call sites. This PR also adds improved conflict reporting and an actual test of such type conflicts.