Skip to content

Move rounding_mode_identifier() to configt #6555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

tautschnig
Copy link
Collaborator

This removes a goto-programs dependency from linking/, which is all
about symbol tables, not goto programs.

Depends on #6554 for all CI checks to pass.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@codecov
Copy link

codecov bot commented Dec 31, 2021

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.39%. Comparing base (22d25d1) to head (96dfda9).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6555      +/-   ##
===========================================
- Coverage    80.39%   80.39%   -0.01%     
===========================================
  Files         1688     1688              
  Lines       207403   207404       +1     
  Branches        73       73              
===========================================
- Hits        166752   166750       -2     
- Misses       40651    40654       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tautschnig tautschnig force-pushed the rounding-mode-symbol branch from a06a215 to b421359 Compare February 5, 2022 21:40
@tautschnig tautschnig changed the title Move rounding_mode_identifier() to configt [depends-on: #6554] Move rounding_mode_identifier() to configt Feb 5, 2022
@tautschnig tautschnig marked this pull request as ready for review February 5, 2022 21:40
@tautschnig tautschnig force-pushed the rounding-mode-symbol branch from b421359 to 933ec9f Compare February 7, 2022 21:30
@tautschnig tautschnig force-pushed the rounding-mode-symbol branch 4 times, most recently from 8b2ec0d to 910a6df Compare November 21, 2022 12:52
@tautschnig tautschnig force-pushed the rounding-mode-symbol branch from 910a6df to e5e443d Compare December 7, 2022 13:42
@peterschrammel peterschrammel removed their assignment Feb 7, 2023
@tautschnig tautschnig self-assigned this May 31, 2023
@tautschnig tautschnig force-pushed the rounding-mode-symbol branch from 6f66e5f to 3f175a0 Compare June 1, 2023 18:30
@tautschnig tautschnig requested a review from TGWDB as a code owner June 1, 2023 18:30
@tautschnig tautschnig removed their assignment Jun 1, 2023
@tautschnig tautschnig force-pushed the rounding-mode-symbol branch from 3f175a0 to f30da5c Compare January 22, 2024 15:08
@tautschnig tautschnig force-pushed the rounding-mode-symbol branch from f30da5c to 7e712c2 Compare May 8, 2024 11:22
@tautschnig tautschnig force-pushed the rounding-mode-symbol branch from 7e712c2 to e2543f8 Compare July 28, 2025 18:09
This removes a goto-programs dependency from linking/, which is all
about symbol tables, not goto programs.
@tautschnig tautschnig force-pushed the rounding-mode-symbol branch from e2543f8 to 96dfda9 Compare July 29, 2025 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants