Skip to content

Makefile builds: add install target #6637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 8, 2022

Conversation

tautschnig
Copy link
Collaborator

Our CMake-based builds already support an "install" target to put
various built binaries (and man pages) in place. Add a similar target to
Makefile-based builds.

Fixes: #6443

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@codecov
Copy link

codecov bot commented Feb 3, 2022

Codecov Report

Merging #6637 (f73d138) into develop (afc53d8) will increase coverage by 0.00%.
The diff coverage is 84.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #6637   +/-   ##
========================================
  Coverage    76.73%   76.73%           
========================================
  Files         1579     1579           
  Lines       181999   181994    -5     
========================================
- Hits        139652   139650    -2     
+ Misses       42347    42344    -3     
Impacted Files Coverage Δ
src/goto-programs/slice_global_inits.h 0.00% <0.00%> (ø)
src/goto-programs/string_instrumentation.h 0.00% <0.00%> (ø)
src/goto-programs/restrict_function_pointers.cpp 80.67% <100.00%> (+0.40%) ⬆️
src/memory-analyzer/gdb_api.h 100.00% <100.00%> (+9.52%) ⬆️
src/solvers/smt2/smt2_tokenizer.h 96.96% <100.00%> (ø)
src/util/exception_utils.cpp 97.77% <100.00%> (+3.43%) ⬆️
src/util/exception_utils.h 92.85% <100.00%> (-7.15%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c351198...f73d138. Read the comment docs.

@tautschnig tautschnig self-assigned this Feb 6, 2022
Our CMake-based builds already support an "install" target to put
various built binaries (and man pages) in place. Add a similar target to
Makefile-based builds.

Fixes: diffblue#6443
@tautschnig tautschnig force-pushed the features/install-target branch from 12c0aed to f73d138 Compare February 8, 2022 10:37
@tautschnig tautschnig removed their assignment Feb 8, 2022
@tautschnig tautschnig merged commit b0f0318 into diffblue:develop Feb 8, 2022
@tautschnig tautschnig deleted the features/install-target branch February 8, 2022 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No way to install CBMC after make -C src
5 participants