remove uses of typet::subtype() const

[kroening]

This commit replaces uses of typet::subtype() const by casting the type to
the applicable subtype, and then using the appropriate accessor method.

• Each commit message has a non-empty body, explaining why the change was made.
• n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
• n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
• Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
• n/a My commit message includes data points confirming performance improvements (if claimed).
• My PR is restricted to a single feature or bugfix.
• n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

[codecov]

Codecov Report

Merging #6878 (84f0644) into develop (381b34d) will increase coverage by 0.01%.
The diff coverage is 88.28%.

@@             Coverage Diff             @@
##           develop    #6878      +/-   ##
===========================================
+ Coverage    77.85%   77.87%   +0.01%     
===========================================
  Files         1574     1576       +2     
  Lines       181245   181537     +292     
===========================================
+ Hits        141109   141370     +261     
- Misses       40136    40167      +31     

Impacted Files	Coverage Δ
...-sensitivity/value_set_pointer_abstract_object.cpp	88.72% <0.00%> (ø)
..._incremental/smt2_incremental_decision_procedure.h	75.00% <ø> (ø)
src/solvers/smt2_incremental/smt_solver_process.h	100.00% <ø> (ø)
src/goto-instrument/contracts/inlining_decorator.h	34.78% <34.78%> (ø)
src/pointer-analysis/value_set_fi.cpp	69.15% <35.71%> (-0.30%)	⬇️
...c/goto-instrument/contracts/inlining_decorator.cpp	62.29% <62.29%> (ø)
jbmc/src/java_bytecode/java_types.cpp	95.10% <84.21%> (-0.14%)	⬇️
...lvers/smt2_incremental/smt_response_validation.cpp	95.58% <86.48%> (-2.30%)	⬇️
jbmc/src/java_bytecode/assignments_from_json.cpp	97.28% <100.00%> (ø)
jbmc/src/java_bytecode/remove_instanceof.cpp	100.00% <100.00%> (ø)
... and 19 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.