Skip to content

Add validation messaging for sorts in SMT get-value responses #7094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

thomasspriggs
Copy link
Contributor

This PR add validation messaging for sorts in SMT get-value responses.

  • Each commit message has a non-empty body, explaining why the change was made.
  • Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Sorry, something went wrong.

This case would previously have failed an invariant in the constructor
of `smt_get_value_responset::valuation_pairt` however with these changes
the error will be reported to the user instead.
In order to clarify that a non-empty collection of
messages/error_messages is an error state.
@codecov
Copy link

codecov bot commented Sep 2, 2022

Codecov Report

Merging #7094 (34429a5) into develop (381b34d) will increase coverage by 0.01%.
The diff coverage is 89.71%.

@@             Coverage Diff             @@
##           develop    #7094      +/-   ##
===========================================
+ Coverage    77.85%   77.87%   +0.01%     
===========================================
  Files         1574     1576       +2     
  Lines       181245   181528     +283     
===========================================
+ Hits        141109   141365     +256     
- Misses       40136    40163      +27     
Impacted Files Coverage Δ
..._incremental/smt2_incremental_decision_procedure.h 75.00% <ø> (ø)
src/solvers/smt2_incremental/smt_solver_process.h 100.00% <ø> (ø)
src/goto-instrument/contracts/inlining_decorator.h 34.78% <34.78%> (ø)
...c/goto-instrument/contracts/inlining_decorator.cpp 62.29% <62.29%> (ø)
...lvers/smt2_incremental/smt_response_validation.cpp 95.36% <90.90%> (-2.52%) ⬇️
src/goto-instrument/contracts/contracts.cpp 96.29% <100.00%> (+1.97%) ⬆️
...c/solvers/smt2_incremental/convert_expr_to_smt.cpp 82.74% <100.00%> (+0.39%) ⬆️
src/solvers/smt2_incremental/response_or_error.h 100.00% <100.00%> (ø)
...ncremental/smt2_incremental_decision_procedure.cpp 96.72% <100.00%> (+0.73%) ⬆️
src/solvers/smt2_incremental/smt_array_theory.cpp 100.00% <100.00%> (ø)
... and 6 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@thomasspriggs thomasspriggs merged commit 67d8c9c into diffblue:develop Sep 5, 2022
@thomasspriggs thomasspriggs deleted the tas/get-value-sort-validation branch September 5, 2022 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants