Add warning about unsound simplification in goto-analyzer #7163
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the time of adding this commit, this simplification is known to return unsound/erroneous results for input programs featuring recursion. This warning should be remove once the known issues have been fixed. See diffblue#7041
thomasspriggs
requested review from
martin-cs,
chris-ryder and
peterschrammel
as code owners
Codecov ReportBase: 77.88% // Head: 77.88% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #7163 +/- ##
========================================
Coverage 77.88% 77.88%
========================================
Files 1576 1576
Lines 181859 181861 +2
========================================
+ Hits 141648 141650 +2
Misses 40211 40211
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
peterschrammel
approved these changes
Oct 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the time of raising this PR, this simplification is known to return unsound/erroneous results for input programs featuring recursion. This warning should be remove once the known issues have been fixed. See #7041
@martin-cs I am not yet that familiar with the goto-analyzer entry point yet. Can you confirm whether the location I have placed this message accurately covers the scope of the issue?