Test builds using clang-14 in CI #7496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
force-pushed
the
bugfixes/clang-14
branch
4 times, most recently
from
7548ed2 to
947b072
Compare
This was referenced Jan 23, 2023
tautschnig
force-pushed
the
bugfixes/clang-14
branch
5 times, most recently
from
b2e0440 to
54a7b5a
Compare
Compiler names may include spaces (such as `ccache gcc`).
Clang warns when bitwise operations are used with Boolean operands.
glibc headers define C99 variants via asm renaming. Library checks (rightly) failed when using clang 14, reporting duplicate definitions. Fixes: diffblue#7366
All functions must be declared before being used, and library checks should not fail due to duplicate definitions.
The rules were already in place, but there was no dependency to ensure invocation.
Ubuntu 22.04 ships version 14 of clang by default. Use it in CI (and not just clang-10, as other jobs already do).
tautschnig
force-pushed
the
bugfixes/clang-14
branch
from
54a7b5a to
4bd1d94
Compare
tautschnig
requested review from
a team,
kroening,
peterschrammel,
chris-ryder and
remi-delmas-3000
as code owners
TGWDB
approved these changes
Jan 25, 2023
There was a problem hiding this comment.
I recognise all the fixes are mostly to get things to work with clang-14, but typically it's nice to be in separate PRs (here it's ok, and in clear commits).
Also it would be good if this was a required job (@peterschrammel ).
| @@ -242,6 +242,76 @@ jobs: | |||
| - name: Run tests | |||
| run: cd build; ctest . -V -L CORE -j2 | |||
|
|
|||
| # This job takes approximately N minutes | |||
There was a problem hiding this comment.
My apologies for failing to clean this up, I've now taken care of this in #7504.
peterschrammel
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ubuntu 22.04 ships version 14 of clang by default. Use it in CI (and not just clang-10, as other jobs already do).