Skip to content

goto-analyzer: support typecasts as left-hand sides #8659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

goto-analyzer: support typecasts as left-hand sides #8659

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions src/analyses/variable-sensitivity/abstract_environment.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,9 +77,13 @@ bool is_ptr_comparison(const exprt &expr)
(expr.operands()[1].type().id() == ID_pointer);
}

static bool is_access_expr(const irep_idt &id)
static bool is_access_expr(const exprt &expr)
{
return id == ID_member || id == ID_index || id == ID_dereference;
if(auto tc = expr_try_dynamic_cast<typecast_exprt>(expr))
return is_access_expr(tc->op());

return expr.id() == ID_member || expr.id() == ID_index ||
expr.id() == ID_dereference;
}

static bool is_object_creation(const irep_idt &id)
Expand Down Expand Up @@ -107,7 +111,7 @@ abstract_environmentt::eval(const exprt &expr, const namespacet &ns) const
return resolve_symbol(simplified_expr, ns);

if(
is_access_expr(simplified_id) || is_ptr_diff(simplified_expr) ||
is_access_expr(simplified_expr) || is_ptr_diff(simplified_expr) ||
is_ptr_comparison(simplified_expr))
{
auto const operands = eval_operands(simplified_expr, *this, ns);
Expand Down Expand Up @@ -168,7 +172,9 @@ bool abstract_environmentt::assign(
std::stack<exprt> stactions; // I'm not a continuation, honest guv'
while(s.id() != ID_symbol)
{
if(s.id() == ID_index || s.id() == ID_member || s.id() == ID_dereference)
if(
s.id() == ID_index || s.id() == ID_member || s.id() == ID_dereference ||
s.id() == ID_typecast)
{
stactions.push(s);
s = s.operands()[0];
Expand Down Expand Up @@ -248,8 +254,8 @@ abstract_object_pointert abstract_environmentt::write(
const irep_idt &stack_head_id = next_expr.id();
INVARIANT(
stack_head_id == ID_index || stack_head_id == ID_member ||
stack_head_id == ID_dereference,
"Write stack expressions must be index, member, or dereference");
stack_head_id == ID_dereference || stack_head_id == ID_typecast,
"Write stack expressions must be index, member, dereference, or typecast");

return lhs->write(*this, ns, remaining_stack, next_expr, rhs, merge_write);
}
Expand Down
Loading