Skip to content

Work around Z3 not producing models for some quantified expressions #8703

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

tautschnig
Copy link
Collaborator

Until the Z3 bug-fix (see Z3Prover/z3#7743) is available widely work around the problem that Z3's preprocessing introduces by adding extra symbols. This may cause solving to take longer, to be determined empirically.

Fixes: #8679

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • n/a My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

@tautschnig tautschnig self-assigned this Jul 31, 2025
Until the Z3 bug-fix (see Z3Prover/z3#7743) is available widely work
around the problem that Z3's preprocessing introduces by adding extra
symbols. This may cause solving to take longer, to be determined
empirically.

Fixes: diffblue#8679
@tautschnig tautschnig force-pushed the trying-to-fix-z3-with-quantifiers branch from b77cf1c to e92bda3 Compare August 5, 2025 17:26
Copy link

codecov bot commented Aug 5, 2025

Codecov Report

❌ Patch coverage is 95.31250% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.39%. Comparing base (6b6c8d3) to head (e92bda3).

Files with missing lines Patch % Lines
src/solvers/smt2/smt2_conv.cpp 95.31% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #8703   +/-   ##
========================================
  Coverage    80.39%   80.39%           
========================================
  Files         1688     1688           
  Lines       207405   207415   +10     
  Branches        73       73           
========================================
+ Hits        166751   166760    +9     
- Misses       40654    40655    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CBMC cannot understand Z3 generating a quantified expression in a counter-example
1 participant