Replace std::endl with \n #891
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reuk
changed the title
tautschnig
requested changes
May 8, 2017
There was a problem hiding this comment.
Spurious ' introduced here.
There was a problem hiding this comment.
Nit picking: please indent << to the same level as the << in the preceding line.
|
I've implemented the quick fixes. I'll try to look at adapting the linter this evening. |
|
Hopefully the linter does the right thing now. |
tautschnig
reviewed
May 9, 2017
scripts/cpplint.py
Outdated
There was a problem hiding this comment.
The '' should be 'runtime/endl'
tautschnig
approved these changes
May 9, 2017
|
A rebase is needed to make the tests pass. |
|
This builds cleanly now. |
|
Looks ready to go once rebased. |
|
Rebased now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
endlforces flushing of the current stream, which is generally not necessary. By avoidingendl, our software becomes faster and more concise, and specifies the required behaviour more accurately. Also, our coding guideline specifies that we should prefer '\n' toendl.