Skip to content

Moved vector_hasht implementation into cpp file #895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

NathanJPhillips
Copy link
Contributor

This breaks the need to have irep_hash.h included in the irep hash container header file, which then propagates it elsewhere. This is important as irep_hash.h defines a macro that clashes with Boost.

This breaks the need to have irep_hash.h included here, which then propagates it elsewhere, which is good as it defines a macro that clashes with Boost
Copy link
Collaborator

@tautschnig tautschnig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that those functions will only be invoked by irep serialisation via irep_hash_container_baset performance should be fine.

@kroening kroening merged commit 915b488 into diffblue:master May 10, 2017
@NathanJPhillips NathanJPhillips deleted the cleanup/break-irep-hash-dependency branch May 10, 2017 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants