Fixed warning in unicode.cpp causing build failure #897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
requested changes
May 9, 2017
src/config.inc
Outdated
|
|
||
| # Treat warnings as errors | ||
| #CXXFLAGS += -Werror | ||
| CXXFLAGS += -Werror |
There was a problem hiding this comment.
As the (failing) AppVeyor build shows, this isn't portable.
NathanJPhillips
force-pushed
the
bugfix/warning-in-unicode
branch
from
f00c1ec to
cd2be27
Compare
Tightened the replacement for MSVC to allow testing it in config.inc
NathanJPhillips
force-pushed
the
bugfix/warning-in-unicode
branch
from
cd2be27 to
10eb073
Compare
|
I've added the correct options for Windows, @tautschnig, but not enabled them as there are a LOT of warnings in the Windows build at the moment. @reuk will probably look into those as a separate PR. It would be good to get this building without errors on all platforms. |
|
I just noticed that as of this change CBMC no longer builds with -O2 by default. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also enabled warnings as errors in config.inc to match travis settings