SMV: past LTL operators #1007
Merged
SMV: past LTL operators #1007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
reviewed
Feb 24, 2025
Comment on lines
+75
to
+80
| bool is_LTL_past(const exprt &expr) | ||
| { | ||
| auto non_LTL_past_operator = [](const exprt &expr) | ||
| { return is_temporal_operator(expr) && !is_LTL_past_operator(expr); }; | ||
|
|
||
| return !has_subexpr(expr, non_LTL_past_operator); |
There was a problem hiding this comment.
Why is that implemented via negation? This makes is_LTL_PAST(nil_exprt{}) return true?
There was a problem hiding this comment.
Yes, that's desired -- say "true" is CTL, LTL, LTL+past, CTL*, etc.
This adds the past LTL operators H, O, S, T Y, Z to the SMV parser.
kroening
force-pushed
the
smv-ltl-past
branch
from
3e727c8 to
72803e5
Compare
tautschnig
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the past LTL operators
H,O,S,T,Y,Zto the SMV parser.